scoring: reduce allocations for addScore #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
approved these changes
Oct 23, 2023
eval.go
Outdated
Comment on lines
39
to
50
| func (m *FileMatch) addScore(what string, computed float64, raw float64, debugScore bool) { | ||
| if computed != 0 && debugScore { | ||
| m.Debug += fmt.Sprintf("%s:%.2f", what, computed) | ||
| if raw != -1 { | ||
| m.Debug += fmt.Sprintf("(%s), ", strconv.FormatFloat(raw, 'f', -1, 64)) // uses the smallest number of digits necessary to represent raw. | ||
| } else { | ||
| m.Debug += ", " | ||
| } | ||
| } | ||
| m.Score += s | ||
| m.Score += computed | ||
| } |
There was a problem hiding this comment.
alternative implementation to still aid reading stuff at the call sites.
func addScore(s float64, debugScore bool, whatFmt string, whatArgs ...any) {
if s != 0 && debugScore {
var b strings.Builder
fmt.Fprintf(&b, whatFmt, whatArgs...)
fmt.Fprintf(&b, ":%.2f, ", s)
m.Debug += b.String()
}
m.Score += s
}What I don't like about what I propose is it was nice to have the string first. Then maybe consider something like
func addScore(what string, s float64, debugScore bool, whatArgs ...any) {
if s != 0 && debugScore {
var b strings.Builder
b.WriteString(what)
for _, v := range whatArgs {
fmt.Fprintf(&b, ":%v", v)
}
fmt.Fprintf(&b, ":%.2f, ", s)
m.Debug += b.String()
}
m.Score += s
}There was a problem hiding this comment.
...any will still cause an alloc. I added the closure to the call sites and updated the code to use strings.Builder because it does read nicer.
|
Fuzz test failed on commit 51eae7c. To troubleshoot locally, use the GitHub CLI to download the seed corpus with |
we add a bit more complexity to addScore but avoid allocation a string if debugScore = false. Test plan: - I ran a couple of benchmarks and checked the allocations.
stefanhengl
force-pushed
the
sh/reduce-allocs
branch
from
51eae7c to
a6cc91d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from this comment.
We add a bit more complexity to addScore but avoid allocating a string if debugScore = false.
Test plan: